Skip to content

New Variant - BlackPill F103C8 #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 29, 2019
Merged

New Variant - BlackPill F103C8 #414

merged 15 commits into from
Jan 29, 2019

Conversation

BennehBoy
Copy link
Contributor

Minor adjustment to BluePillF103C8 Variant to support BlackPillF103C8 - LED_BUILTIN is on PB12 instead of PC13.

@BennehBoy
Copy link
Contributor Author

Thought I'd mention that the following are tested and working:

USART
SPI
CDC
HID Bootloader
LED

Not yet tested
I2C
Analogue read/write

@BennehBoy
Copy link
Contributor Author

I2C working
Analogue read working

fpistm and others added 13 commits January 25, 2019 09:37
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
I thought I had set the I2C pins to the arduino compatible
values, but it seems I messed that up. This change will
set the defaults for the board variant RemRam V1.
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic.Pillon <frederic.pillon@st.com>
@fpistm fpistm self-requested a review January 26, 2019 13:59
@fpistm fpistm added the new variant Add support of new bard label Jan 26, 2019
@BennehBoy
Copy link
Contributor Author

Analogue read tested and working.
I2C tested and working.

Any more testing required Frederic? This one seems reasonably safe...

@fpistm fpistm added this to the 1.5.0 milestone Jan 29, 2019
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if a small typo issue. This could be fixed later.

@@ -44,7 +44,7 @@ extern "C"{
*----------------------------------------------------------------------------*/
extern const PinName digitalPin[];

// USB connector on the top, MCU side
// Bluepill USB connector on the top, MCU side - Blackpill USB connector on bottom, MCU Side (pins are reversed vertically for Arduino Ananlog pin correct sequence.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick note:
Avoid line length > 80
Small typo: Analog

@fpistm fpistm merged commit e275b8e into stm32duino:master Jan 29, 2019
@BennehBoy BennehBoy deleted the blackpill branch January 29, 2019 15:29
benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants